Skip to content

fix: reset search mini-form when we have no data / an empty response#18055

Merged
magento-engcom-team merged 1 commit into2.2-developfrom
unknown repository
Sep 24, 2018
Merged

fix: reset search mini-form when we have no data / an empty response#18055
magento-engcom-team merged 1 commit into2.2-developfrom
unknown repository

Conversation

@DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Sep 14, 2018

Description

Currently the search form does not reset the results when we have no result / data.

Fixed Issues (if relevant)

Manual testing scenarios

  1. go to http://mag2opensource.basecom.de/catalogsearch/result/?q=pullover
  2. write pullover in the search
  3. autocomplete with result number appears
  4. now append en so we have pulloveren
  5. autocomplete still shows the results

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 14, 2018

Hi @DanielRuf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@phoenix128 phoenix128 self-assigned this Sep 17, 2018
@phoenix128
Copy link
Contributor

phoenix128 commented Sep 17, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 17, 2018

Hi @phoenix128. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 17, 2018

Hi @phoenix128, here is your new Magento instance.
Admin access: https://pr-18055.engcom.dev.magento.com/admin
Login: admin Password: 123123q

phoenix128
phoenix128 suggested changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@phoenix128 phoenix128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @DanielRuf ;
thank you for this contribution and for your ime, please check my review.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Sep 17, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 17, 2018

Hi @phoenix128, thank you for the review.
ENGCOM-2995 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 15876b7 into magento:2.2-develop Sep 24, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 24, 2018
ENGCOM-2995: fix: reset search mini-form when we have no data / an em…
190c23e 
…pty response #18055
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 24, 2018

Hi @DanielRuf. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@dmytro-ch dmytro-ch mentioned this pull request Sep 28, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@phoenix128 phoenix128 phoenix128 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phoenix128 phoenix128

Labels

Area: Frontend Component: Search Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielRuf @magento-engcom-team @phoenix128